fix(web): remove message center entry points - #6347
Conversation
lefarcen
added
size/M
PerishCode
left a comment
PerishCode
left a comment
There was a problem hiding this comment.
@lefarcen This cleanly removes both web-shell message-center entry points and the associated polling/unread-indicator state while preserving the standalone implementation and notification settings for future work. I verified all four changed ranges, including the signed-in and signed-out regression coverage and the updater test’s semantic replacement assertion. The focused local run could not start because this prepared reviewer worktree has no installed Vitest binary, but the implementation and reported validation are consistent. Nice focused cleanup—thank you for keeping the underlying capability intact while aligning the visible shell with the product decision.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.
Visual regression reviewHead:
0 changed · 0 unchanged · 47 new without baseline · 0 failed New cases without baselines
27 additional new case(s) omitted from this comment. Visual diff is advisory only and does not block merging. |
|
Closing as superseded by the later product decision in e22a289 (#6162), authored by CHENGLONG WANG: the Message Center is intentionally exposed from the left rail/account menu with persistent unread polling and unread indicators. The current feat/workspace-team tip contains that commit and those entry points. Removing them would regress the newer product baseline. |
2 participants
Why
Product has explicitly decided that the web client should not expose a notification or message-center entry yet. The current workspace shell still showed one in the signed-in account menu and another in the signed-out navigation rail, so users could open an unsupported surface and the rail kept polling message-center data solely for those entry points.
This PR removes that premature web-shell exposure while preserving the standalone message-center implementation, its client/data contracts, notification settings, and daemon capabilities for future product work.
What users will see
Signed-in users no longer see “Message center” in the account menu. Signed-out users no longer see a message-center item below Settings. The rest of the account menu, signed-out Settings entry, task notification settings, and system notification behavior are unchanged.
Surface area
apps/webodsubcommand or flag, newtools-dev/tools-packflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates/, orcraft/, or change to the skills protocolpackage.jsonScreenshots
The changed UI is the absence of two controls. The focused DOM regression test covers both signed-in and signed-out shell branches and is more precise than an empty-space screenshot; no other visual layout is changed.
Bug fix verification
apps/web/tests/components/EntryNavRail.message-center-entry.test.tsxorigin/feat/workspace-team@4a4dfadd: yes, both signed-in and signed-out assertions failed because the entries were present.Validation
pnpm --filter @open-design/web exec vitest run -c vitest.config.ts tests/components/EntryNavRail.message-center-entry.test.tsx --maxWorkers=1(2/2)pnpm exec vitest run -c vitest.config.ts tests/components/EntryNavRail*.test.ts* tests/components/MessageCenter.test.tsx --maxWorkers=2fromapps/web(15 files, 90/90)pnpm --filter @open-design/web typecheckpnpm --filter @open-design/web buildpnpm guardpnpm typecheckgit diff --check origin/feat/workspace-team...HEAD